Skip to content

chore: resolving swift formatting errors #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

chore: resolving swift formatting errors #3906

wants to merge 16 commits into from
+58,728 −43,039

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented Oct 24, 2024 •
edited
Loading

Issue #

Description

Merging previously reviewed and approved code changes to resolve swift formatting errors and warnings:

Updates were made that weren't previously reviewed can be seen from this commit: f944c94

Swift linting failure is expected due to formatting changes impacting code with pre-existing lint errors that have not been resolved. This can be ignored, considered out of scope of formatting changes.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner October 24, 2024 16:04
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 58.22690% with 556 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.01%. Comparing base (acdd2dc) to head (f0cb73c).

Files with missing lines Patch % Lines
...urces/AWSAPIPlugin/AWSAPIPlugin+RESTBehavior.swift 26.86% 98 Missing ⚠️
...Model/Internal/Schema/ModelSchema+Definition.swift 60.71% 44 Missing ⚠️
Amplify/DevMenu/View/IssueReporter.swift 0.00% 27 Missing ⚠️
Amplify/Categories/DataStore/Query/ModelKey.swift 9.09% 20 Missing ⚠️
...Categories/DataStore/Subscribe/MutationEvent.swift 0.00% 20 Missing ⚠️
...plify/Core/Support/Internal/InternalTask+Hub.swift 20.00% 20 Missing ⚠️
...gin/Configuration/AWSAPIEndpointInterceptors.swift 51.51% 16 Missing ⚠️
...urces/AWSAPIPlugin/Core/AppSyncModelMetadata.swift 55.55% 16 Missing ⚠️
...ries/DataStore/Subscribe/MutationEvent+Model.swift 0.00% 15 Missing ⚠️
...WSUnifiedLoggingPlugin/Internal/OSLogWrapper.swift 71.42% 12 Missing ⚠️
... and 99 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3906      +/-   ##
==========================================
+ Coverage   67.81%   68.01%   +0.19%     
==========================================
  Files        1129     1129              
  Lines       52472    54637    +2165     
==========================================
+ Hits        35585    37162    +1577     
- Misses      16887    17475     +588
Flag Coverage Δ
API_plugin_unit_test 70.15% <68.76%> (-0.19%) ⬇️
AWSPluginsCore 69.50% <ø> (+0.25%) ⬆️
Amplify 47.89% <49.44%> (-0.04%) ⬇️
Analytics_plugin_unit_test 85.59% <ø> (+0.38%) ⬆️
Auth_plugin_unit_test 73.04% <ø> (-0.76%) ⬇️
DataStore_plugin_unit_test 84.60% <ø> (+1.16%) ⬆️
Geo_plugin_unit_test 75.95% <ø> (+1.08%) ⬆️
Logging_plugin_unit_test 65.56% <ø> (+0.50%) ⬆️
Predictions_plugin_unit_test 34.63% <ø> (-0.14%) ⬇️
PushNotifications_plugin_unit_test 88.76% <ø> (+0.32%) ⬆️
Storage_plugin_unit_test 78.90% <ø> (-0.09%) ⬇️
unit_tests 68.01% <58.22%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

harsh62
harsh62 previously approved these changes Oct 24, 2024
View reviewed changes
phantumcode and others added 14 commits September 18, 2025 11:04
@phantumcode @thisisabhash
chore: resolve SwiftFormat errors and warnings at the categories modu…
a9acad1 
…le (#3843)

* resolve swiftformat errors and warnings

* resolve review comments

* move braces back to same-line

* fix argument spacing
@phantumcode @thisisabhash
chore(analytics): resolve swiftformat errors and warnings (#3844)
e0337f2 
* chore(analytics): resolve swiftformat errors and warnings

* chore(analytics): resolve swiftformat errors and warnings

* resolve review comments

* fix build errors
@phantumcode @thisisabhash
chore(notifications): resolve swiftformat errors and warnings (#3853)
3f707a1 
* chore(notifications): resolve swiftformat errors and warnings

* updated swiftformat rules
@phantumcode @thisisabhash
chore(datastore): resolve swiftformat errors and warnings (#3848)
998d018 
* chore(datastore): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* update rules

* fix build error

* fix brace alignment
@phantumcode @thisisabhash
chore(api): resolve swiftformat errors and warnings (#3845)
867e2d8 
* chore(api): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* update rules
@phantumcode @thisisabhash
chore(logging): resolve swiftformat errors and warnings (#3850)
8bf6c6b 
* chore(logging): resolve swiftformat errors and warnings

* updated swiftformat rules
@phantumcode @thisisabhash
chore(geo): resolve swiftformat errors and warnings (#3849)
669c210 
* chore(geo): resolve swiftformat errors and warnings

* updated swiftformat rules

* update rules
@phantumcode @thisisabhash
chore(predictions): resolve swiftformat errors and warnings (#3851)
971e030 
* chore(predictions): resolve swiftformat errors and warnings

* updated swiftformat rules

* remove duplicate import statement
@phantumcode @thisisabhash
chore(core): resolve swiftformat errors and warnings (#3847)
8072be3 
* chore(core): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* fix build error

* update rules
@phantumcode @thisisabhash
chore: resolve swiftformat errors and warnings in test modules (#3854)
9e0d3ad 
* chore: resolve swiftformat errors and warnings

* updated swiftformat rules

* update rules
@phantumcode @thisisabhash
chore(storage): resolve swiftformat errors and warnings (#3852)
14bcc82 
* chore(storage): resolve swiftformat errors and warnings

* updated swiftformat rules

* update rules
@phantumcode @thisisabhash
chore(auth): resolve swiftformat errors and warnings (#3846)
3ad897b 
* chore(auth): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* fix build error

* update rules

* fix build error

* remove commented code

* align comments

* fix spacing
@phantumcode @thisisabhash
resolve latest swift format changes
264a0c9
@thisisabhash
chore: resolve build failure after rebase with main
943b6b6
@thisisabhash thisisabhash force-pushed the chore/resolve_swiftformat branch from f944c94 to 943b6b6 Compare September 18, 2025 22:39
@thisisabhash thisisabhash deployed to IntegrationTest September 18, 2025 23:16 — with GitHub Actions Active
@thisisabhash
Copy link
Member

Successful integration tests run:
https://github.com/aws-amplify/amplify-swift/actions/runs/17843756355
https://github.com/aws-amplify/amplify-swift/actions/runs/17843752236
https://github.com/aws-amplify/amplify-swift/actions/runs/17843737588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phantumcode @thisisabhash @harsh62